configury: always require Python for building Open MPI #13254
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
No code or logic changes Signed-off-by: Jeff Squyres <[email protected]>
Ensure that we can still configure if there is no Fortran compiler. Signed-off-by: Jeff Squyres <[email protected]>
Commit cb4fe48 didn't quite get the Python configury tests correct. This commit fixes several issues: * Move the AM_INIT_AUTOMAKE up before we call AM_PATH_PYTHON. * Since we converted a few Perl scripts to Python in a60b03b, we now *always* need Python to build Open MPI. Multiple Python scripts are invoked post-configure (i.e., reacting to configure results -- see a60b03b) to build the C and Fortran and MPI bindings. * Since we now always have Python, remove the OMPI_GENERATE_BINDINGS AM_CONDITIONAL. * Use the slightly-more-correct $(PYTHON) in Makefile.am (vs. $(python)). Signed-off-by: Jeff Squyres <[email protected]>
bosilca
approved these changes
May 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See individual commit messages for details. The main / important commit in this PR has the following commit message:
Commit cb4fe48 didn't quite get the Python configury tests correct. This commit fixes several issues:
Move the AM_INIT_AUTOMAKE up before we call AM_PATH_PYTHON.
Since we converted a few Perl scripts to Python in a60b03b, we now always need Python to build Open MPI. Multiple Python scripts are invoked post-configure (i.e., reacting to configure results -- see a60b03b) to build the C and Fortran and MPI bindings.
Since we now always have Python, remove the OMPI_GENERATE_BINDINGS AM_CONDITIONAL.
Use the slightly-more-correct
$(PYTHON)in Makefile.am (vs.$(python)).